Please rename bin/sample to have a more project-specific name

[yurivict]

Otherwise, it might conflict with some other executables.
Or, maybe consider removing it altogether, because this behavior is not common for python packages.

[abradle]

Sorry I don’t quite understand what you mean?

[yurivict]

Please, do not install /usr/local/bin/sample.

[abradle]

Could you show me in the code where we reference bin/sample? Ideally a pull request would be great. Happy to help - still unclear what we’re doing wrong.

[yurivict]

Distutils installs 'bin/sample' because of these lines in setup.py:

https://github.com/rcsb/mmtf-python/blob/master/setup.py#L106

    entry_points={
        'console_scripts': [
            'sample=sample:main',
        ],
    },

Installing the /usr/local/bin/sample executable can easily conflict with other packages.
Please either rename 'sample', or delete it altogether.

[abradle]

Thanks that’s awesome! And quite stupid from me. I’ll fix.

…

On Sun, 13 May 2018 at 19:35, ***@***.*** ***@***.***> wrote: Distutils installs 'bin/sample' because of these lines in setup.py: https://github.com/rcsb/mmtf-python/blob/master/setup.py#L106 entry_points={ 'console_scripts': [ 'sample=sample:main', ], }, Installing the /usr/local/bin/sample executable can easily conflict with other packages. Please either rename 'sample', or delete it altogether. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFuRIYJ8kv6hsjv7qdsj9vsrDoqr5aYpks5tyG7igaJpZM4T84Ez> .

[abradle]

Done - thanks!