rdegges/django-twilio

[Question] Why this is not avalaible for Django 2.0.x ?

nicolasmendoza opened this issue · 11 comments

[Question] Why this is not avalaible for Django 2.0 ?. What's the reasons of "incompatibility" ?

django-twilio 0.9.3 has requirement Django<2.2,>=2.1; python_version >= "3.5", but you'll have django 2.0.6 which is incompatible.

Thanks.

jheld commented

Hi @nicolasmendoza

It's possible this is simply a bug in the setup.py syntax.

However, I do see the following there:

'Django>=1.8,<2.2;python_version>="3.4, <3.7"',
'Django>=2.1,<2.2;python_version>="3.5"',

Are you unable to install the library with your current environment setup?

jheld commented

I was trying to make it as close to the django supported environment as possible (admittedly we support a wider gamut for the short term).

https://docs.djangoproject.com/en/1.11/faq/install/#what-python-version-can-i-use-with-django

@jheld yes, it's not possible install the library on Django 2.0.x, PY3.6 because the setup.py have this restriction.

Anyway I forked the project and I'm using the library on django 2.0.6 on PY3.6 without any inconvenient so I didn't understand why the "limitation".

jheld commented

@nicolasmendoza ok. I'm sorry for the bug! This django 2.1 support was hard for me to get right.

I'm totally fine releasing a new build today provided we can get the syntax correct.

I wonder why travisCI didn't warn me about the build error...

Can you please share your code change as a snippet or PR?

Thanks!

jheld commented

I tried to install on my local using py3.6, and was able to install all of the requirements. I did have to explicitly reinstall django==2.0.* (2.1 comes by default via requirements.txt in the project), but that did work.) I was able to run the runserver in this environment.

Just so you know (I do understand that you had an install issue), this is the travis CI test that passed: https://travis-ci.org/rdegges/django-twilio/jobs/416614222

Would you be able to send over a snippet of our changes, or a PR of them? I'd be happy to quickly release a new version.

@jheld Sorry for the delay, I'm "on fire" the last days but I'll try to provide you a pull request soon.

Thanks!

jheld commented

@nicolasmendoza any updates? Just so we don't forget.

km-pg commented

I'm getting a similar error with python 3.7.2 and Django 1.11.18.

Does this mean that django-twilio doesn't support Django 1.11? Or does setup.py just need to be updated to include this configuration?

Python 3.7 support was added to the Django 1.11 series as of 1.11.17
https://docs.djangoproject.com/en/2.1/releases/1.11.17/

jheld commented

@km-pg thank you. I didn't see it was newly supported. Yes, it sure can be included!

km-pg commented

Great to hear! Thanks

jheld commented

Setup support has been added. Please reopen if 0.10.0 still has issues.