Support for other wiki languages than English

Question

Closed this issue 7 years ago · 4 comments

We have some stupid hard-coded strings which might be different for different languages.

See this screenshot of code climate for hints on where to fix it:

Looking into it.

Answer 1 · 2017-07-27T12:01:19.000Z

Do @mwjames or @kghbln have some input on the most idiomatic way to access i18ed NSes?

I found something about the SMW_NS_PROPERTY constant ... but still looking for the best way to access the i18n version ...

Answer 2 · 2017-07-27T14:20:30.000Z

I think I know the solution now:

$titleWithNS = Title::makeTitleSafe( SMW_NS_PROPERTY, $theTitle )->getFullText();

... etc.

(EDIT: getTitleValue() → getFullText())

Answer 3 · 2017-07-27T19:27:25.000Z

The changes are now implemented, as of cca71be and fcd2823 . Now just need to test this with another language somehow.

Answer 4 · 2017-07-27T22:26:42.000Z

This is now tested manually, so closing (a CI would still be great).