re-actors/alls-green

The execution status still green

Closed this issue · 1 comments

Sorry, maybe I don't understand how this action should work, but I added the check to my workflow, but I didn't get the expected result. Why is the execution status (number 1 in the screenshot) still green?

  check:
    if: always()
    runs-on: [self-hosted]
    needs:
    - dev_build_int_tests

    steps:
    - name: Install python3
      uses: actions/setup-python@v4
      with:
        python-version: '3.10'

    - name: Decide whether the needed jobs succeeded or failed
      uses: re-actors/alls-green@v1.2.2
      with:
        jobs: ${{ toJSON(needs) }}

2022-11-29_14-57

Sounds like you might be using something like continue-on-failure: true in those jobs, which makes GitHub set a successful outcome for them. The red crosses don't correspond to outcome but to result which may still be failing.