reach/reach-ui

[menu-button]: target="_blank" for MenuButton / MenuLink

Emina198 opened this issue ยท 0 comments

๐Ÿš€ Feature request

Either or both the MenuButton and MenuLink should have an option to propagate a target for the link.

Current Behaviour

At the moment we can attach the target="_blank" to the MenuLink directly as a prop, but it doesn't work.

Desired Behaviour

Attaching a target prop should work as described.

Who does this impact? Who is this for?

It impacts everyone who wants to use the link and expects it to have link behaviour.

Describe alternatives you've considered

A workaround is to wrap the MenuItem in both a and an element, like so:

<Link
    href={{pathname: ROUTE}}
    passHref
    >
    <a target="_blank">
        <MenuItem>Link</MenuItem>
    </a>
</Link>