onChange called onOpen
ZeHiro opened this issue · 6 comments
ZeHiro commented
When clicking on the closed picker, with a defaultColor set, the onChange callback is called, even before the user even changes the value.
I expect the onChange callback to be called only when the user changes the value.
ZeHiro commented
Looking at the code, this seems to be wanted :
color-picker/src/ColorPicker.jsx
Line 112 in fe256c8
I don't undertand why.
webyonet commented
+1
ZeHiro commented
Anyone @react-component to tackle this problem ?
yutingzhao1991 commented
Anyone want make a PR ?
ZeHiro commented
if the fix is only to delete the this.props.onChange i can, but I am not able to test all the possiblities.