Add support for Electron

Question

Add support for Electron

piranna opened this issue 7 years ago · 17 comments

Add support for Electron as a target platform. According to this tutorial seems Electron apps can be heavily based on the web ones, being main difference the usage of non-relative-protocol URLs, that could be easily checked and change before building the Electron bundle.

Answer 1 · 2017-07-20T18:46:35.000Z

Hi @piranna,
I've been working on this lately, please check the electron branch. Plan is to add support to master by this weekend.

Answer 2 · 2017-07-20T19:10:24.000Z

Cool! I'll take a look in the next days :-)

Answer 3 · 2017-07-23T20:35:16.000Z

Is there any way to update a project? Or should I apply these changes by hand?

Answer 4 · 2017-07-24T05:48:03.000Z

as of now, you have to do it by hand but there needs to be a way to do it. I'll look into it.

Answer 5 · 2017-08-11T14:59:31.000Z

Any update on this?

Answer 6 · 2017-09-17T21:09:27.000Z

I see the README.md has been updated to reflect the electron changes and the code seems to be there but the npm package doesn't include it.

Looks like using file path for --template isn't building correctly. Not sure if that is intended. I get a lot of incorrect peer dependency XYZ as well from file path off master I get cannot lstat(node_modules/re-start)

Answer 7 · 2017-09-17T21:15:28.000Z

Dependencies are a bit outdated, I'm trying to have them up-to-date on my project but it's not possible to doing so with all of them. Also peerDependency problems seems to be common, there's a lot of dependencies that themselves depend on several versions. I think it would be a difficult one to fix.

Answer 8 · 2017-10-01T18:59:52.000Z

Hey,
sorry for the delay, i'll update all the dependencies soon after react-native releases their version compatible with react 16 (that'll be react-native 0.49 I think) and also update the npm package with electron support.

Answer 9 · 2017-10-01T19:02:29.000Z

Ok, thanks. Currently I have been keeping updated some of the dependencies, maybe I could be able to do a pull-requests with them if you want...

Answer 10 · 2017-10-01T19:05:02.000Z

That would be great :)

Answer 11 · 2017-10-01T19:11:10.000Z

That would be great :)

I'll try to find some time to do it, there are some other fixed that need to be done too :-)

Answer 12 · 2017-10-25T11:09:51.000Z

Just encountered the same when trying out this project (which I want to use primarily for Electron now, and for native later).
react-native has 0.49.3 with React 16 now

Answer 13 · 2017-10-25T11:15:31.000Z

Pull-request for React 16 are welcome :-)

Answer 14 · 2017-10-25T11:21:45.000Z

I'm experienced with React but am very new to react-native and all flavors of it. So cannot help here unfortunately, was hoping for this proj to help me get started :)

Answer 15 · 2017-10-25T12:39:11.000Z

Hey @emirotin
Have a look at #29. This will be merged into master soon.

Answer 16 · 2017-10-25T13:03:37.000Z

Nice @amoghbanta let me try it out!

Answer 17 · 2017-10-31T16:19:28.000Z

Master now has the support for electron and I've published it to npm.
Closing this one.