react-native-community/react-native-template-typescript

App.tsx fails linter

tsargent opened this issue · 2 comments

For some reason each non-empty line in App.tsx begins with a whitespace character. It seems like there's probably a good reason for it, and the file gets overwritten anyway, but it causes some confusion when running the linter.

Expected results

After running
npx react-native init MyApp --template react-native-template-typescript and running yarn lint inside MyApp, I would expect the linter not to find errors. It is only linting the version of App.tsx found in this repo.

Observed results

The linter fails because each non-empty line of code begins with a whitespace character.

Logs

➜  MyApp git:(master) yarn lint
yarn run v1.22.10
$ eslint . --ext .js,.jsx,.ts,.tsx

/Users/tylersargent/Code/MyApp/App.tsx
   11:1   error  Delete `·`  prettier/prettier
   12:1   error  Delete `·`  prettier/prettier
   13:3   error  Delete `·`  prettier/prettier
   14:1   error  Delete `·`  prettier/prettier
   15:3   error  Delete `·`  prettier/prettier
   16:1   error  Delete `·`  prettier/prettier
   17:1   error  Delete `·`  prettier/prettier
   18:3   error  Delete `·`  prettier/prettier
   19:3   error  Delete `·`  prettier/prettier
   20:1   error  Delete `·`  prettier/prettier
   22:1   error  Delete `·`  prettier/prettier
   23:3   error  Delete `·`  prettier/prettier
   24:1   error  Delete `·`  prettier/prettier
   25:3   error  Delete `·`  prettier/prettier
   26:1   error  Delete `·`  prettier/prettier
   27:1   error  Delete `·`  prettier/prettier
   28:1   error  Delete `·`  prettier/prettier
   30:1   error  Delete `·`  prettier/prettier
   31:1   error  Delete `·`  prettier/prettier
   32:1   error  Delete `·`  prettier/prettier
   33:1   error  Delete `·`  prettier/prettier
   34:1   error  Delete `·`  prettier/prettier
   35:5   error  Delete `·`  prettier/prettier
   36:7   error  Delete `·`  prettier/prettier
   37:1   error  Delete `·`  prettier/prettier
   38:11  error  Delete `·`  prettier/prettier
   39:11  error  Delete `·`  prettier/prettier
   40:1   error  Delete `·`  prettier/prettier
   41:11  error  Delete `·`  prettier/prettier
   42:1   error  Delete `·`  prettier/prettier
   43:1   error  Delete `·`  prettier/prettier
   44:7   error  Delete `·`  prettier/prettier
   45:1   error  Delete `·`  prettier/prettier
   46:9   error  Delete `·`  prettier/prettier
   47:1   error  Delete `·`  prettier/prettier
   48:11  error  Delete `·`  prettier/prettier
   49:1   error  Delete `·`  prettier/prettier
   50:11  error  Delete `·`  prettier/prettier
   51:1   error  Delete `·`  prettier/prettier
   52:1   error  Delete `·`  prettier/prettier
   53:7   error  Delete `·`  prettier/prettier
   54:1   error  Delete `·`  prettier/prettier
   55:1   error  Delete `·`  prettier/prettier
   56:1   error  Delete `·`  prettier/prettier
   58:1   error  Delete `·`  prettier/prettier
   59:1   error  Delete `·`  prettier/prettier
   61:3   error  Delete `·`  prettier/prettier
   62:1   error  Delete `·`  prettier/prettier
   63:1   error  Delete `·`  prettier/prettier
   65:3   error  Delete `·`  prettier/prettier
   66:1   error  Delete `·`  prettier/prettier
   67:1   error  Delete `·`  prettier/prettier
   68:1   error  Delete `·`  prettier/prettier
   69:9   error  Delete `·`  prettier/prettier
   70:9   error  Delete `·`  prettier/prettier
   71:1   error  Delete `·`  prettier/prettier
   72:9   error  Delete `·`  prettier/prettier
   73:1   error  Delete `·`  prettier/prettier
   74:1   error  Delete `·`  prettier/prettier
   75:11  error  Delete `·`  prettier/prettier
   76:1   error  Delete `·`  prettier/prettier
   77:1   error  Delete `·`  prettier/prettier
   78:13  error  Delete `·`  prettier/prettier
   79:11  error  Delete `·`  prettier/prettier
   80:1   error  Delete `·`  prettier/prettier
   81:13  error  Delete `·`  prettier/prettier
   82:11  error  Delete `·`  prettier/prettier
   83:1   error  Delete `·`  prettier/prettier
   84:13  error  Delete `·`  prettier/prettier
   85:11  error  Delete `·`  prettier/prettier
   86:1   error  Delete `·`  prettier/prettier
   87:13  error  Delete `·`  prettier/prettier
   88:11  error  Delete `·`  prettier/prettier
   89:1   error  Delete `·`  prettier/prettier
   90:9   error  Delete `·`  prettier/prettier
   91:1   error  Delete `·`  prettier/prettier
   92:1   error  Delete `·`  prettier/prettier
   93:3   error  Delete `·`  prettier/prettier
   94:1   error  Delete `·`  prettier/prettier
   96:1   error  Delete `·`  prettier/prettier
   97:3   error  Delete `·`  prettier/prettier
   98:5   error  Delete `·`  prettier/prettier
   99:1   error  Delete `·`  prettier/prettier
  100:3   error  Delete `·`  prettier/prettier
  101:1   error  Delete `·`  prettier/prettier
  102:1   error  Delete `·`  prettier/prettier
  103:5   error  Delete `·`  prettier/prettier
  104:3   error  Delete `·`  prettier/prettier
  105:1   error  Delete `·`  prettier/prettier
  106:5   error  Delete `·`  prettier/prettier
  107:1   error  Delete `·`  prettier/prettier
  108:1   error  Delete `·`  prettier/prettier
  109:3   error  Delete `·`  prettier/prettier
  110:1   error  Delete `·`  prettier/prettier
  111:1   error  Delete `·`  prettier/prettier
  112:3   error  Delete `·`  prettier/prettier
  113:1   error  Delete `·`  prettier/prettier
  115:1   error  Delete `·`  prettier/prettier

Steps to reproduce

npx react-native init MyApp --template react-native-template-typescript
cd MyApp
yarn lint

@tsargent I saw the same issue in App.tsx but it was a simple fix with prettier plugin. I would imagine it depends on the lint config one's using.

This got broken in 739f9e7, and should be fixed in my opinion. At least I cannot see a reason to keep it like this. :-/