react-native-webrtc/react-native-webrtc-web-shim

Props are not handled as expected

Opened this issue · 5 comments

gavrilikhin-d commented

Describe the bug
If you use mirror prop, then you would get:

Warning: Received `true` for a non-boolean attribute `mirror`.

If you want to write it to the DOM, pass a string instead: mirror="true" or mirror={value.toString()}.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)

Versions (please complete the following information):

  • React Native Version: 0.73.2
  • React Native Web Version: 0.19.10
  • React Native WebRTC Version: 118.0.0
gavrilikhin-d commented

Same goes for objectFit

Warning: React does not recognize the `objectFit` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `objectfit` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)
gavrilikhin-d commented

And zOrder :)

agent.ts:1 Warning: React does not recognize the `zOrder` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `zorder` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at video
    at Video
    at RTCView (webpack://mobile/./node_modules/react-native-webrtc-web-shim/src/RTCView.web.js?:1:1135)
8BallBomBom commented

Planned for the next release, can't confirm exact functionality at this point 🤔
But the idea is to have everything function the same between platforms.

DavidGOrtega commented

👋 When is the next release?

8BallBomBom commented

Currently focused on a few projects including new arch support for the main rn webrtc repo.
But this is planned to be worked on within the coming weeks in-between that.

  • 👍1