Update to style-components v4

Question

Update to style-components v4

Opened this issue 6 years ago · 5 comments

I think this package will benefit a lot if it is updated to styled-components v4

Answer 1 · 2019-02-18T19:57:56.000Z

Thanks! I'm not that familiar with v4 changes. Could you explain a bit further why you think is that?

Answer 2 · 2019-02-18T20:05:25.000Z

From what I understand v4 is smaller, but also mounts faster due to some refactoring and optimisations around memory usage and JS engine implementation details.

Answer 3 · 2019-02-18T20:07:21.000Z

Ok. Sounds good!
I'll try to take a look at this soon, but I still have some other issues to tackle before this 😅 .
Feel free to jump on this if you like!

Answer 4 · 2019-02-19T08:37:03.000Z

One nice issue that I can't do, is the support of SVGs for react-pdf :)

Answer 5 · 2019-02-22T02:37:09.000Z

I just checked this, and it wouldn't be that simple to implement. The main cause is that styled-components v4 does not export the lib dir but just the bundles. I'm not going to work on this in the near future, so if someone feels like tackling this, please do!