react-ui-org/react-ui

TextField setting size

mbohal opened this issue · 1 comments

The TextField component accepts a prop named size (

size: PropTypes.oneOf(['small', 'medium', 'large']),
)

This however prevents us from specifying the size HTML attribute (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/text#size) on the actual <input type="text" /> HTML element. Normally this would have been done by forwarding HTML attributes (https://github.com/react-ui-org/react-ui/tree/master/src/lib/components/TextField#forwarding-html-attributes).

I think we need to use a non colliding name for our props and maybe even consider prefixing the props to prevent collisions in the future. The size prop is used by several other components.

The <input type="text" > size can be controlled via the inputSize prop.