Inherit link color in components with feedback/validation states
mbohal opened this issue · 5 comments
@davidurban proposes that the local context color should be used everywhere where the context element can changes color to provide some information to the user.
Thank you for your proposal. However, we need to discuss it a bit more deeply before we can dispatch it to engineering.
- We need to clarify what means "everywhere [where the context element can changes color]". There are two relevant situations:
- components that use Feedback Colors (but there components with both light (
Alert) and dark (Badge) background, what then?), - components that use Validation State Colors (but there is also the default state, see the input on the left).
- components that use Feedback Colors (but there components with both light (
- We need to decide if links in the default validation state should be gray too — that's a BC.
- RUI only: should the color inheritance feature be optional globally / per component / not at all?
- Agree with both.
- They should not be gray, but default TextLink colour (theme.colors.primary).
- No opinion.
I also think we will need to eventually start supporting feedback colours on most components (like Paper, Modal, Tabs…) because of needs of Generated UIs. There a node (represented by Paper, or Tap) can become invalid and we will need to visually indicate it. Having ability to use Feedback Colours would greatly improve DX and consistency. In such cases, container links should also inherit the colour.
we will need to eventually start supporting feedback colours on most components (like Paper, Modal, Tabs…)
Generally I think the same.

