react95-io/React95

Issue with peggysPastels theme

traverse opened this issue ยท 4 comments

So I was trying out React95 today, first off kudos it's awesome ๐Ÿ‘ but I ran into an issue with one of the themes. I was trying to make the theme dynamically select-able but ran into the following issue.

./node_modules/react95/dist/themes/peggysPastels.js
Module not found: Can't resolve '../utils' in 'path\to\project\node_modules\react95\dist\themes'

It seems all the utils are missing from the built package when looking through the files. My best guess that it might be something with the rollup config but I haven't used rollup before so not 100% sure.

Hey @traverse! โค๏ธ can you reproduce the issue on codesandbox?

Yep that's no problem! Here you go https://codesandbox.io/s/practical-mountain-n2keq?file=/src/App.js

Edit: also noticed a minor issue with the aiee theme the canvasText color is wrongly set to rgb(0,62,1090) think the last number should be 109.

@traverse yes indeed! both canvasText and checkmark have wrong rgb colors. Wanna create PR fixing this? :)

We have fixed this on #289 and it is part of v3.12.2.