Incorrect documentation for subscription.request

Question

Incorrect documentation for subscription.request

tferi-da opened this issue 6 years ago · 5 comments

I believe this line is misleading.
According to rule 3.17 if demand exceeds Long.MAX_VALUE the publisher should keep working, and may become unbounded. There's even a test which is checking that demand beyond Long.MAX_VALUE is tolerated without errors.

Answer 1 · 2018-09-25T12:53:42.000Z

Hi @tferi-da,

Thanks for opening this issue!

I'm inclined to agree with your assessment,
what do you think about amending it as such:

 * It can be called however often and whenever needed—but if the outstanding cumulative demand ever becomes Long.MAX_VALUE or more, it may be treated by the {@link Publisher} as "effectively unbounded".

Answer 2 · 2018-09-25T12:58:33.000Z

Yes @viktorklang, I think that's much better. Thank you for responding so quickly.

Answer 3 · 2018-09-25T13:30:42.000Z

@reactive-streams/contributors Wdyt?

Answer 4 · 2018-11-12T15:12:57.000Z

@reactive-streams/contributors Ping.

Answer 5 · 2019-01-08T12:34:32.000Z

Thank you for the fix @viktorklang