reactiveui/ReactiveUI

Bounce transition duration support

glen-nicol opened this issue · 3 comments

Is your feature request related to a problem? Please describe.
I was experiementing with the transitions in the WPF RoutedViewHost and noticed the duration property didn't have any effect when Bounce was set as the transition type. Sure enough I saw the code doesn't use the duration property when setting up bounce. I'm guessing that is because that animation uses key frames?

Describe the solution you'd like
I'd really like to be able to shorten the animation a little bit.

Describe alternatives you've considered
Use a different transition that uses duration.

Describe suggestions on how to achieve the feature
I haven't done much with animations in C code so forgive my ignorance. Is there a scale function that will stretch or compress the keyframe timestamps to match a new duration proportionally? Seems like that could be done fairly easily as a copy and mutate operation too.

Additional context

I would be willing to work this if my assumption about the lack of support is correct. If there is another reason that is more complicated I will just live with it or use a different transition.

Hi, Thank you for raising this, currently the animations are defined in XAML with some predetermined timelines to follow, making an adjustment to the overall time alone wouldn't be sufficient to maintain the overall animation sequence in a variant time period.
I will see if we can move these to a C# code-based animation sequence to allow more flexibility.

k, should I wait for you to investigate before making some attempts myself?

I'm currently working in Brazil, but as soon as I return I will make time to do some refactoring to convert the XAML into C# code thereby giving more flexibility.