Option to wrap a modal inside a NavigationPage

[modplug]

When I do PushModal from my viewmodel, the modal shows just fine. But as a good citizen I added a "Close" Toolbar button in the top right corner so that the user can opt out of the modal. The button is never shown because the modal doesn't have a NavigationPage.

I've used similiar frameworks before and I think MvvmCross has an option to "WrapInNavigationPage" when pushing modals.

An alternate solution would perhaps be to do this by using interactions, but that might trick the IViewStackService

There should be an option to wrap it in a NavigationPage.

Additional context

Screenshot nr 2 is the modal page without the NavigationBar.

[open-collective-bot]

Hey @modplug 👋,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider backing us.

https://opencollective.com/reactiveui

PS.: We offer priority support for all backers. Don't forget to add priority label when you start backing us 😄

ReactiveUI - Open Collective

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!

[giusepe]

Possibly a regression caused by #96 or even earlier in the 1.7.*
I tested with the version 1.5.5 and works as intended, but the view/viewmodel registration is different.

Thanks for trying the bleeding edge version and reporting the bug, just a heads up that version 1.7.* is a WIP that will become 2.0 and more suitable for production.

[RLittlesII]

@modplug I think I found the issue going to do a bit of checking around and verify that I haven't broken anything else. It was a regression issue with how we are registering the NavigationView.
👍 @giusepe for that thought.

[RLittlesII]

@modplug If you get the chance can you pull the beta bits and verify this solves your problem?