Housekeeping: Change MS MicrosoftDependencyResolver to require IKeyedServiceProvider in ctor
dpvreony opened this issue · 2 comments
Please note although we can't commit to any timeline, priority will be given to those who are Contributors to the project.
If this is a question please ask on StackOverflow.
Is your feature request related to a problem? Please describe.
With #1075 to avoid a breaking change that would effectively drop NET6 early and cause a headache it was suggested to revisit how IKeyedServiceProvider logic works in the DI wrapper.
With #1075 it carries out an interface type check to see if it's using IKeyedServiceProvider.
Describe the solution you'd like
This can be simplified by changing the constructor to require IKeyedServiceProvider instead of IServiceProvider. The default implementation of ServiceProvider uses IKeyedServiceProvider as of net 8.
Then we can remove the if checks and the older contract internal class that's in there for net6.
Describe alternatives you've considered
Leave as is
Describe suggestions on how to achieve the feature
Additional context
technically we've already broken net6 package support as the framework is using v8 of packages
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.