No ID listed in warnings
Closed this issue · 8 comments
I added the ID back in #14 so we could actually find the elements producing warnings.
What's the point of warning without a direct reference to where it's being produced?
Putting the ID only on elements that were failing was great because I had some CSS targeting *[id^=a11y-] { which would cause broken elements to fade in and out so you could find them. The animation is also very irritating which motivates fixing it immediately.
So now after upgrading I can't find the elements throwing warnings and I can't style broken elements.
you should activate this option a11y(React, { includeSrcNode: true });
@blairanderson what does that option do? It doesn't seem to be documented?
I belive I did. That's why this is prefixed with Pushmenu, but that doesn't actually help me find the element, just the Component.
I ran into enough problems trying to upgrade it made more sense to just give up and go back to my old fork of the project.
No, I had to create a fork when I had a bunch of PRs here that weren't merged. They have been merged, but everything I've done has been changed. What I can say is that my fork works for my project and this version doesn't any more. It was more work than I'm willing to do to change that.
Got it, thanks.
@joeybaker It shows the offending HTML element...
its documented on the README:
If you want to log DOM element references for easy lookups in the DOM inspector, use the includeSrcNode option.
a11y(React, { includeSrcNode: true });
I believe this has been answered and the reporting has changed since this was posted. I'm going to close this now but please feel free to re-open if you're still having issues with the latest version.