Review process
ltmylinh opened this issue · 4 comments
ltmylinh commented
This issue is created to discuss about review process:
- How many approvals do we need for a PR?
- Who will take responsibility to merge PR?
nampdn commented
-
To make the review process solid, I think we should have at least 1 approval.
-
At this time, we are only 2 maintainers, I think both of us can merge if a PR is approved.
ltmylinh commented
I prefer at least 2 approvals. More reviewers will have good quality.
We have @anhphamduy in our team, right?
Quynh-Nguyen commented
huyqdang commented
Yo yo, I want to help as well.