Aligning the Publication models with Kotlin
mickael-menu opened this issue · 0 comments
mickael-menu commented
readium/r2-shared-swift#83, readium/r2-streamer-swift#153 and readium/r2-navigator-swift#106 partially fix this issue, I'll strike the items progressively.
This Kotlin PR refactored the Publication models and introduced a lot of changes needing to be replicated on Swift:
Add missing values inReadingProgression
Fix the computing of theReadingProgression
(see readium/architecture#113)- Review the Date parsing from ISO 8601
- Use an interface for
PositionListFactory
and add unit tests for each format- (POSTPONED: Let's see how the Streamer API will look like first)
- Use a dictionary for
LocalizedString
Add the Presentation Hints extensionMovePage
andOrientation
fromProperties
toPresentation
RemovescrollContinuous
PublicationRenameaddSelfLink
tosetSelfLink
RenameContentLayoutStyle
toContentLayout
and add testsRenameresourceWithRelativePath
toresourceWithHref
We should not filter outLink
without arel
here: https://github.com/readium/r2-shared-swift/blob/cb2420f4dee0cc8cd55dce59329ab1f87cca01af/r2-shared-swift/Publication/Web%20Publication/WebPublication.swift#L51
OPDSMoveOPDSPrice
,OPDSAcquisition
to the OPDS folderAdd missing OPDS objects and extensionsRenameindirectAcquisition
toindirectAcquisitions
EPUBRemovemedia-overlay
from the EPUB extension and fromLink
Movemetadata.layout
tometadata.presentation.layout
RenamelistOfAudioFiles
tolistOfAudioClips
, andlistOfVideos
tolistOfVideoClips
RemoveEPUBRendition
and useEPUBLayout
insteadMoveEPUBLayout.fromEPUB
to the EPUB parserExtract theencrypted
object to a newEncryption
extensionRenameoriginal-length
tooriginalLength
(but still parse the old one for backward compatibility)
(streamer) Don't parse<readingOrder>
, only<spine>
is valid in the OPFinotherMetadata
, resolvedc
metadata to thedcterms
UR.
Locators:Add HTML extension
- Review the new unit tests in
r2-streamer-kotlin
, in particular:- Fix OEBPS 1.2 DTD
- Additions in NCX
- OPF tests regarding the EPUB versions