advanced compilation

Question

advanced compilation

edbond opened this issue 10 years ago · 4 comments

Use advanced compilation and add externs

Answer 1 · 2014-11-26T17:21:33.000Z

Just to be sure... Is that a request for examples of advanced compilation and externs?

Answer 2 · 2014-11-26T17:25:46.000Z

would be nice to see all examples converted to advanced.
Or just one example. Maybe a notice about externs for 3rd party libs.
It's up to you. I just noticed advanced not used and know it may cause problems when devs will try to minify javascript size.

Answer 3 · 2014-11-29T20:52:02.000Z

Thanks for bringing this up - that makes sense to me! Eventually will try and add advanced compilation to the reagent-seed template. In the interim, we will probably make an example recipe.

Answer 4 · 2015-09-13T18:15:40.000Z

Long over due ... but better late than never right? Just migrated the recipes to use :advanced compilation and externs.

Also, I am new to using externs, and couldn't get them to work for the mermaid and nvd3 recipes (which can be found in the old-recipes section). I would love a PR from anyone willing to update those recipes to :advanced compilation with the necessary externs!