deriving via Last

Question

deriving via Last

Closed this issue 4 years ago · 2 comments

The persistent use of Last adds a fair bit of noise to using this library, both when transforming attributes, and when looking at document ASTs (which are otherwise very readable with pretty-simple).

In recent GHC versions, we could get the same behaviour by using DerivingVia for the Monoid instances, without needing to wrap everything.

This would of course be a breaking change, and I'd understand if you don't think it's worth it.

Answer 1 · 2021-01-02T12:21:31.000Z

I think it would be worth it.

Answer 2 · 2021-01-02T13:47:26.000Z

Great. I'll get to work.