reasonml/reason-native

refmterr doesn't support OCaml 4.09.0

smorimoto opened this issue · 3 comments

smorimoto commented
refmterr doesn't support OCaml 4.09.0
jordwalke commented

Thanks, how did you discover this issue? We need to fix this.

mnxn commented

I've noticed this too.
Simplest esy project to reproduce is just this package.json:

{
  "name": "refmterr-ocaml49",
  "dependencies": {
    "ocaml": "4.9.0"
  },
  "devDependencies": {
    "refmterr": "3.2.2"
  }
}

Explanation is pretty simple, both the opam and esy file for refmterr have constraints to exclude ocaml 4.09.0:
https://github.com/facebookexperimental/reason-native/blob/master/refmterr.json#L22
https://github.com/facebookexperimental/reason-native/blob/master/refmterr.opam#L15

I built refmterr on my machine with ocaml 4.09.0 and it seemed to build with no problems. Should be a fairly simple fix to update the constraints.

  • 👍1
smorimoto commented

As @mnxn said, if you try to use refmterr on a project using OCaml 4.09.0 or later, you will get an error.