Changing Theme during runtime is buggy and doesn't update all values

Question

Changing Theme during runtime is buggy and doesn't update all values

Opened this issue 6 months ago · 1 comments

barrymichaeldoyle commented 6 months ago

Describe the bug

When implementing a theme toggle functionality. i.e. changing from one theme to another during runtime. The graph does not update all the colors.

Steps to Reproduce the Bug or Issue

Implement a toggle feature in the app as follows (you can use the default light and dark themes)

return (
    <GraphCanvas
      actives={actives}
      draggable
      layoutType="hierarchicalLr"
      cameraMode="pan"
      edges={edges}
      nodes={nodes}
      onCanvasClick={onCanvasClick}
      onNodeClick={handleNodeClick}
      ref={graphRef}
      selections={selections}
      theme={theme === "light" ? lightTheme : darkTheme}
      edgeInterpolation="linear"
    />
)

You will see the same problem effective even if you just update the theme during development and watch it incorrectly re-render with HMR