fix: Dockerfile allows conditional full requirements
richtong opened this issue · 3 comments
richtong commented
Do you want this fix? basically I need to develop with full requirements sometimes so I modified the dockerfile with a conditional build so the right requirements is copied (also you don't need RUN mkdir, WORKDIR does this already. so docker build --build-arg BUILD=full -t slashgpt .
works
ARG BUILD=base
FROM python:3.11.5-bookworm as slashgpt_base
ONBUILD COPY requirements.txt requirements.txt
FROM python:3.11.5-bookworm as slashgpt_full
ONBUILD COPY requirements/full.txt requirements.txt
RUN pip install -r requirements.txt
RUN pip install playsound
FROM slashgpt_${BUILD}
RUN git clone https://github.com/snakajima/SlashGPT.git
WORKDIR /SlashGPT/SlashGPT
COPY .env .env
Also I added something to Makefile as well to make the loop faster so that make docker
just drops you into the container :-)
isamu commented
Thank you!
I would like to merge the docker additions and readme changes.
richtong commented
Ok will prepare a PR
Sent via Superhuman iOS ( ***@***.*** )
…On Fri, Mar 22 2024 at 13:23, isamu arimoto < ***@***.*** > wrote:
Thank you!
I would like to merge the docker additions and readme changes.
—
Reply to this email directly, view it on GitHub (
#285 (comment) )
, or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AANTCR7ULMD6E3ONMECTF2LYZSHL3AVCNFSM6AAAAABFDU6OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHA2DSNJQGQ
).
You are receiving this because you authored the thread. Message ID: <snakajima/SlashGPT/issues/285/2015849504
@ github. com>
richtong commented
:-$
Sent via Superhuman iOS ( ***@***.*** )
…On Sat, Mar 23 2024 at 01:16, Rich Tong < ***@***.*** > wrote:
Ok will prepare a PR
Sent via Superhuman iOS ( ***@***.*** )
On Fri, Mar 22 2024 at 13:23, isamu arimoto < ***@***.*** >
wrote:
>
>
>
>
>
>
> Thank you!
> I would like to merge the docker additions and readme changes.
>
>
>
> —
> Reply to this email directly, view it on GitHub (
> #285 (comment) )
> , or unsubscribe (
> https://github.com/notifications/unsubscribe-auth/AANTCR7ULMD6E3ONMECTF2LYZSHL3AVCNFSM6AAAAABFDU6OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHA2DSNJQGQ
> ).
> You are receiving this because you authored the thread. Message ID: <snakajima/SlashGPT/issues/285/2015849504
> @ github. com>
>
>
>