recksjs/recks

Let's add prettier?

Closed this issue · 7 comments

demensky commented

I was very interested in this project. Do you mind if I add .editorconfig and prettier here?

kosich commented

🙂
Hi again, Dmitry! Yeah, let's add it!

Got a question regarding this:
What is the best way to ensure prettier has been run before pushing to remote?
Maybe we should add some git hook to do that?

demensky commented

For automation I usually use husky and lint-staged, I can do something like this here.

demensky commented

I can't configure bots and GitHub Actions.

kosich commented

For automation I usually use husky and lint-staged, I can do something like this here.

I think we can start with husky/lint-staged to add prettifying on before commit, and later we'll investigate some CI (like GithubActions) checks.

Sounds ok?

kosich commented

Also, can we exclude .md files, so docs will be manually formatted?

I want to still have ability to fine-tune docs code examples

demensky commented

Also, can we exclude .md files, so docs will be manually formatted?

Sure.

I want to still have ability to fine-tune docs code examples

Do you want to exclude the examples folder?

kosich commented

I thought of maybe dropping/moving examples folder.
Please, exclude it for now too -- we'll figure out what to do with it later.
Thx!