[DOCTRINE_COLLECTION_22] constant to enum error for querybuilder

Question

[DOCTRINE_COLLECTION_22] constant to enum error for querybuilder

Closed this issue 3 days ago · 5 comments

When i use DOCTRINE_COLLECTION_22 it will replace my Doctrine\\Common\\Collections\\Criteria::DESC to Doctrine\Common\Collections\Order::DESCbut this causes the following error:TypeError: Doctrine\ORM\QueryBuilder::orderBy(): Argument #2 ($order) must be of type ?string, Doctrine\Common\Collections\Order given, called in /srv/Repository/BlogRepository.php on line 103`

The replacement should actually be Doctrine\\Common\\Collections\\Order::DESC->value @julienfastre asked if this would maybe cause problems see: #297 (comment)

I think we should replace with the ->value call?

Answer 1 · 2024-07-04T11:17:32.000Z

Thanks for reporting! Fix you suggest would be great 👍

Answer 2 · 2024-07-04T11:51:55.000Z

Not sure its a good idea: as I remember, in issue #315, it was discussed that, maybe:

we should not replace the "ASC" and "DESC" strings by constants in annotations,
but we should keep the replacement where those string (or the previous constants) are in use as argument in Criteria::orderBy

But any help for improving this is welcome 😸

Answer 3 · 2024-07-04T12:53:53.000Z

@julienfastre Would it fix this bug? 🙏

Answer 4 · 2024-07-05T16:20:04.000Z

I'll try to find some time next week or the week after, @TomasVotruba .

Answer 5 · 2024-07-31T22:32:51.000Z

Regarding to this comment, do you think that we should remove all usage of Criteria::ASC and Criteria::DESC outside of a Criteria::orderBy by the 'ASC' and 'DESC' string ?