reddit-archive/reddit-plugin-robin

TTL on presence makes people not present if they've been connected a while

spladug opened this issue · 4 comments

The presence messages are edge-triggered, so if a user is connected for more than two minutes the presence marker will TTL away and other users refreshing the page will see them as away. That's a bummer.

Could:

  • rely on edge triggering, remove the ttl
  • or have some sort of periodic ping over amqp

Will a user ever disconnect without triggering a websocket disconnect message? Can we get rid of the TTL and rely on that?

In normal operation they can disconnect silently, but it should time out after a bit (~1 minute) and send the message. However, if a socket server is restarted or killed we won't get messages appropriately. Hopefully in that situation most people would be reconnecting though.

I'd vote for pinging. That would increase websocket traffic and potentially writes to the presence CF?

Just amqp and Cassandra traffic. There are already periodic ping messages
on the socket side.

I'm pretty worried about sending more rabbit traffic than necessary because
of our recent issues.
On Mar 30, 2016 2:15 AM, "kjoconnor" notifications@github.com wrote:

I'd vote for pinging. That would increase websocket traffic and
potentially writes to the presence CF?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#47 (comment)