Kombu SQS Compatibility
Opened this issue · 3 comments
Currently, the connection_from_config
method is very AMQP focused. Kombu has underlying support for AWS SQS, but our wrapper to generate connections is unable to take advantage of it because hostname
is a required field on the call, but is incompatible with SQS queue URLs in the Kombu SQS implementation. My thought on this is to add an optional arg to connection_from_config
to indicate that the queue is SQS (or maybe a list of known strings for different behavior, defaulting to AMQP if the arg isn't specified), and alter the config parser to make hostname
optional in that scenario. Would there be another preferred way to implement this?
This isn't fully blocking usage of SQS in baseplate, as engineers can simply create a Connection
manually.
I'm looking at Qasim's docs on how he sets up the SQS consumers and it looks like he's passing a hostname of sqs://
. Does that pass through the config OK?
I'll have to go back and look, but when I last talked to him, he was explicitly creating a Connection
object manually and it didn't pass through correctly without that.