reddit/baseplate.py

get_all_experiment_names doesn't return experiments from self._global_cache

Closed this issue · 2 comments

Problem:

To get an experiment baseplate.lib.experiments.init._get_experiment use two sources:

  • self._global_cache
  • self._cfg_data

But baseplate.lib.experiments.init.get_all_experiment_names use only self._cfg_data

Solution:

Add self._global_cache usage to get_all_experiment_names

Thanks for the report! I'm not sure I understand what the cache would do here? We're not actually doing the conversion from stringy dictionaries to experiment objects here, but instead just iterating over the string keys in the dictionary.

I'm going to close this out. Please reopen if you think there's still an issue.