reddr/LibScout

confusing error message when LibScout finds no APKs in a dir

Closed this issue · 3 comments

When running LibScout on a directory that has no APKs, it gives an error that made me think that I had wrong command line flags:

$ mkdir /tmp/newdir
$ java -jar build/LibScout.jar -o match -a lib/android-23.jar -p profiles  /tmp/newdir/
 
Command line parsing failed:
You have to provide a path to a single application file or a directory
reddr commented

You are right, the error message is confusing.

It should say something like "no APKs found in /tmp/newdir". I guess the hard question is whether that example is an error or not. An error would be useful when the user is expecting there to be APKs there, but it might be annoying when running batches using the xargs trick, e.g.:

$ find ~/data/ -mindepth 2 -maxdepth 2 -type d \
	| xargs -P8 -n1 java -jar build/LibScout.jar -o match -a lib/android-23.jar -p profiles -j json -s stats -d logs  
reddr commented

Fixed with 69cd762