redfin/react-server

Cannot start React Server website

Closed this issue · 3 comments

This was introduced by a change in Asini version. It's not clear to me if it's an Asini bug or if we need to update the instructions to start the service.

Reproduction

  1. Follow the instructions in the react-server-website README:
$ git clone git@github.com:redfin/react-server.git
$ cd react-server
$ npm run bootstrap
$ cd packages/react-server-website
$ npm run build-assets

Bug

$ npm run build-assets

> react-server-website@0.5.1 build-assets /Users/david.alber/tmp/rstest/react-server/packages/react-server-we$
site
> npm run docs && NODE_ENV=production react-server compile


> react-server-website@0.5.1 docs /Users/david.alber/tmp/rstest/react-server/packages/react-server-website
> docco -o docs ./components/*.js ./lib/*.js ./middleware/*.js ./pages/*.js *.js && node build-dir-contents.js

sh: docco: command not found

npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/david.alber/.nvm/versions/node/v6.9.4/bin/node" "/Users/david.alber/.nvm/versions/node/v6.9.4/bin/npm" "run" "docs"
npm ERR! node v6.9.4
npm ERR! npm  v3.10.10
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! react-server-website@0.5.1 docs: `docco -o docs ./components/*.js ./lib/*.js ./middleware/*.js ./pages/*.js *.js && node build-dir-contents.js`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the react-server-website@0.5.1 docs script 'docco -o docs ./components/*.js ./lib/*.js ./middleware/*.js ./pages/*.js *.js && node build-dir-contents.js'.

This was introduced in 7f11ef1.

As a workaround, if you run asini bootstrap again, it will link the hoisted docco package.

@davidalber I submitted a PR to asini (asini/asini#80) which fixes this issue. Once a new version of asini is published, we can upgrade our dependency to use that and you'll be good.

Thanks, @drewpc!