[mock-as-war goal] add support for maven 2.2.1 and maven 3.1.x
redfish4ktc opened this issue · 6 comments
The 1st implementation (see #4) will only support maven 3.0.x as it used sonatype aether to retrieve dependencies. These dependencies are then packaged in the war.
Maven 2.2.1 has no aether support and maven 3.1.x use eclipse aether.
We should use the maven abstraction to retrieve dependencies
More information here
- maven 3.1.0 information release: http://aheritier.net/united-colors-of-maven/ (with the list of maven plugin that support maven 3.1.0, so have an aether fix)
- examples of plugins that use maven-model to fix that kind of issue
With current implementation (4.6.4.0), the plugin fails when running with maven 3.0.2 (see #120) When implementing this, check what is the minimum 3.0.x version that works with the plugin
Seeing that this issue has been left untouched for almost 2 years - is this plugin still being maintained?
If yes, we should get it to support newer Maven versions (I'm currently using 3.3.9). I am willing to contribute, if that will help.
Hi @hbjastad
I have currently limited time to work on this plugin, but if you want to contribute go on and I will merge your pull request
Ok, I have a fix ready - I tried to push a new remote branch, but I don't have access. Do you want to give me access, so that you can get a pull request?
Hi
Please clone the repo on GitHub, push your modifications on your clone repo and then create the pull request
Le 21 juil. 2016 à 09:56, hbjastad notifications@github.com a écrit :
Ok, I have a fix ready - I tried to push a new remote branch, but I don't have access. Do you want to give me access, so that you can get a pull request?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Note: the #138 pull request provides a native eclipse aether solution to add support to maven 3.1+