redhat-cop/infra.osbuild

Remove custom repos after the image using the custom repo is built

matoval opened this issue · 3 comments

We should remove custom repos after the image using the custom repo is built so we can avoid conflicts.

Background:
When the microshift repos are added as sources and we try to build a non microshift image we are getting a conflict error:

file /usr/share/redhat-release/EULA conflicts between attempted installs of redhat-release-eula-8.7-0.3.el8.x86_64 and redhat-release-coreos-410.84-2.el8.x86_64

Remove the microshift sources resolve this issue and there doesn't seem to be an negative in adding and removing custom repos every time they are needed.

@matoval I think we currently do this for custom repos, but do not for the subscription manager repos. Yes?

@matoval I think we currently do this for custom repos, but do not for the subscription manager repos. Yes?

@maxamillion We are doing this for custom repos when building an installer but for other image types we leave the custom repos as sources.
I think we should only add a custom repo as a source during the image build process then remove it once the image is built.

Looks like this issue was caused by a build failing and Ansible exited out before disabling the custom repos. Issue #97 was created to address cleaning up custom repos if a build fails.