Replace dc with bc

[faysou]

In the readme this instruction

oc set env dc/s2i-dotnetcore-persistent-ex --from=secret/postgresql -e database-service=postgresql

needs to be replaced with this instruction

oc set env bc/s2i-dotnetcore-persistent-ex --from=secret/postgresql -e database-service=postgresql

(bc for buildconfig instead of dc of deploymentconfig)

Thank you

[omajid]

Thanks for opening this issue!

I just tried this out and I can't help but think it's correct as-is.

In the oc set env command, we want to set up the environment of the deployment, not the build. It's the deployment that needs access to the postgres database, including the secrets and database service.

I just tried it out and the original command works fine as written.

Can you please share more information on why you think it needs to be changed from dc to bc?

cc @tmds

[faysou]

I think you are right, in my notes I'm using dc as well. I don't remember in which context I needed to switch to bc. I think you can close the issue, sorry for this.