GitHub is mis-cased in the edit image

Question

GitHub is mis-cased in the edit image

Closed this issue a year ago · 7 comments

Answer 1 · 2021-03-19T19:00:34.000Z

This image has been removed so this issue is closed. @amoralej can you close this one?

Answer 2 · 2021-03-19T20:10:04.000Z

I'm not sure what you mean. The image is still very much in https://github.com/redhat-openstack/website/blob/master/source/images/edit.png and https://github.com/redhat-openstack/website/tree/master/source/images

If you either fix the content of the image or delete the image from the tip of master, then it's removed.

Until then, the file itself is an attractive nuisance -- someone may choose to use it thinking it's good, when it's in fact bad.

If you're no longer using the file, then deleting it should be a pretty simple task.

Answer 3 · 2021-03-19T20:34:02.000Z

Josh we removed the image from the site as part of another issue.

…

On Mar 19, 2021, at 3:10 PM, Josh Soref ***@***.***> wrote: I'm not sure what you mean. The image is still very much in https://github.com/redhat-openstack/website/blob/master/source/images/edit.png and https://github.com/redhat-openstack/website/tree/master/source/images If you either fix the content of the image or delete the image from the tip of master, then it's removed. Until then, the file itself is an attractive nuisance -- someone may choose to use it thinking it's good, when it's in fact bad. If you're no longer using the file, then deleting it should be a pretty simple task. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 4 · 2021-03-19T20:35:06.000Z

Great, so you can delete the file from the repository, would it help if I created the PR for it?

Answer 5 · 2021-03-19T20:52:44.000Z

Josh we switched to using Gerrit for patches and reviews. You're more than welcome to put up a patch at https://review.rdoproject.org/r/ or I can do it for you.

…

On Fri, Mar 19, 2021 at 3:35 PM Josh Soref ***@***.***> wrote: Great, so you can delete the file from the repository, would it help if I created the PR for it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1421 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5YEIGKFYY5QPUGJSKE2X3TEOYQXANCNFSM4VDF3BHA> .

Answer 6 · 2021-03-19T20:56:12.000Z

Please do it for me, thanks.

Answer 7 · 2023-04-07T11:46:03.000Z

https://review.rdoproject.org/r/c/rdo-website/+/32620