redis-rb/redis-client

Make it easier to discern between errors from Redis Sentinel vs. Redis nodes

Closed this issue · 1 comments

stanhu commented

Related to #176, we had a difficult time discerning that ERR max number of clients reached was sent from the Redis Sentinels instead of the Redis nodes when Redis::CommandError was raised.

Some ideas to improve this:

  1. Raise a different exception, such as Redis::Sentinel::CommandError.
  2. Add more details in the error message to identify the host that originated the error.
byroot commented

2 makes sense, we should attach the config to the raised exception and render the server url in there (without password obviously).