redis/go-redis

[Proposal] Monitor go-redis with https://github.com/alibaba/opentelemetry-go-auto-instrumentation

123liuziming opened this issue · 8 comments

I found that go-redis doesn't have the ability to integrate tracing and metrics by default and there doesn't seem to be a best practice in the documentation on how to monitor go-redis applications. Our project(https://github.com/alibaba/opentelemetry-go-auto-instrumentation) allows tracing and metrics(will be supported later) to be collected and reported on the go-redis app without making changes to user code. I was wondering if it would be possible for me to add an observable subsection to the official documentation for this project that describes best practices for observing the go-redis application. Thanks!

why this does not work for you?

github.com/redis/go-redis/extra/redisotel/v9

but yeah, need to mention it more prominently

why this does not work for you?

github.com/redis/go-redis/extra/redisotel/v9

but yeah, need to mention it more prominently

github.com/redis/go-redis/extra/redisotel/v9 need to add hook manually in user's code. We want to provide a zero-code-modification way to do that. I wanna add a document to mention the two ways more prominently

hm, adding hook single time in main.go is not too much trouble. and probably better than pre-compile source code modification by very large code-processing tool.

anw, I am not a fan of that tool, and github.com/redis/go-redis/extra/redisotel/v9 looks ok to me (despite it having couple bugs)

but good point redis docs should mention more directly somewhere how to enable instrumentation. it took me a couple google searches to find out that this code exist in this repo!