redis/lettuce

SPUBLISH not working for Reactive/Coroutines client when using pubsub connection

jkrauze opened this issue · 4 comments

jkrauze commented

Bug Report

https://github.com/redis/lettuce/pull/2838/files#r1727231070

As per comment I left on that PR, the spublish() command in RedisPubSubReactiveCommandsImpl points to publish command instead of spublish.

This causes spublish() command to point to a wrong underlying command when using a pubsub connection (initiated with .connectPubSub() method).

Please note that the spublish() works fine when we use a regular connection.

Current Behavior

redisClient.connectPubSub().coroutines().spublish("test", "test")

this calls PUBLISH test test

redisClient.connect().coroutines().spublish("test", "test")

this calls SPUBLISH test test

Expected behavior/code

both should call SPUBLISH test test

Environment

  • Lettuce version(s): 6.4.0.RELEASE
  • Redis version: 7.0

Possible Solution

correct the typo

Additional context

jkrauze commented

opened a PR fixing this typo

tishun commented

Wondering why the integration tests have not caught this issue. Please, give me a little time to verify that.

  • 👍1
tishun commented

Wondering why the integration tests have not caught this issue. Please, give me a little time to verify that.

Well the answer is we did not have tests for that :/

tishun commented

@jkrauze thank you for the contribution!

  • 👍1