redis/redis-om-python

Packaging issues

Opened this issue · 1 comments

beenje commented

Hello,
I have a project depending on redis-om and wanted to submit it to conda-forge.
I encountered some packaging issues:

  • If I run make dist locally, I only get the following directories in the wheel 
    aredis_om
redis_om-1.0.3b0.dist-info
    redis_om is missing. I have to patch the pyproject.toml to add { "include" = "redis_om" } to packages.
  • Looking at the latest wheel on pypi redis_om-0.3.5-py3-none-any.whl, I noticed it includes the following directories: 
    aredis_om
docs
images
redis_om
redis_om-0.3.5.dist-info
    docs and images should be in the sdist but not in the wheel as this will be installed under site-packages. It properly includes redis_om. How is the wheel created?
  • python-ulid is pinned to `"^1.0.3" which is very restrictive. Version 2 was released in 2023 and version 3 in 2024. I haven't seen any breaking changes. Could the upper bound be removed?
abrookins commented

Thanks for opening! Let me check out the wheel/build configuration. Also, the ULID change seems reasonable.

  • 👍1