redis/riot

Logs missing / gets cut off when viewing in different screen sizes

pamelayin opened this issue · 2 comments

Riot version 3.1.1

When using riot -i <source> replicate <target> --mode compare --show-diffs, the log gets cut off after Value mismatch for string "xxx so it's impossible to identify the mismatching key. Please see log line below at 20:23:33.672 for details.

20:23:28.410 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-job]] launched with the following parameters: [{}]
20:23:28.435 INFO org.springframework.batch.core.job.SimpleStepHandler  : Executing step: [compare-step]
Comparing   0% [                                            ]    0/5006 (0:00:00 / ?) ?/s
20:23:28.946 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-step-reader-left]] launched with the following parameters: [{}]
20:23:28.952 INFO org.springframework.batch.core.job.SimpleStepHandler  : Executing step: Comparing  43% [ ] 2200/5006 (0:00:04 / 0:00:05) 550.0/s 0 missing, 0 type, 0 value, 0 tt
20:23:33.672 SEVERE com.redis.riot.cli.Replicate        : Value mismatch for string "ods_sComparing  96% [ ] 4850/5006 (0:00:08 / 0:00:00) 606.2/s 0 missing, 0 type, 1 value, 0 tt
20:23:37.855 INFO org.springframework.batch.core.step.AbstractStep      : Step: [compare-step-reader-left-step] executed in 8s903ms
20:23:37.860 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-step-reader-left]] completed with the following parameters:Comparing  99% [ ] 5000/5006 (0:00:09 / 0:00:00) 555.6/s 0 missing, 0 type, 1 value, 0 tt
20:23:38.057 SEVERE com.redis.riot.cli.common.CompareStepListener       : Verification faiComparing 100% [=] 5006/5006 (0:00:09 / 0:00:00) 556.2/s 0 missing, 0 type, 1 value, 0 tt
20:23:38.068 INFO org.springframework.batch.core.step.AbstractStep      : Step: [compare-step] executed in 9s633ms
20:23:38.070 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-job]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 9s643ms

Same thing happens when the command was run without --show-diffs. Log gets cut off after Verification fai. Please see log line below at 20:28:47.525.

20:28:37.719 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-job]] launched with the following parameters: [{}]
20:28:37.744 INFO org.springframework.batch.core.job.SimpleStepHandler  : Executing step: [compare-step]
Comparing   0% [                                            ]    0/5006 (0:00:00 / ?) ?/s
20:28:38.257 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-step-reader-left]] launched with the following parameters: [{}]
20:28:38.263 INFO org.springframework.batch.core.job.SimpleStepHandler  : Executing step: Comparing  98% [ ] 4950/5006 (0:00:09 / 0:00:00) 550.0/s 0 missing, 0 type, 1 value, 0 tt
20:28:47.323 INFO org.springframework.batch.core.step.AbstractStep      : Step: [compare-step-reader-left-step] executed in 9s60ms
20:28:47.328 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-step-reader-left]] completed with the following parameters:Comparing  99% [ ] 5000/5006 (0:00:09 / 0:00:00) 555.6/s 0 missing, 0 type, 1 value, 0 tt
20:28:47.525 SEVERE com.redis.riot.cli.common.CompareStepListener       : Verification faiComparing 100% [=] 5006/5006 (0:00:09 / 0:00:00) 556.2/s 0 missing, 0 type, 1 value, 0 tt
20:28:47.537 INFO org.springframework.batch.core.step.AbstractStep      : Step: [compare-step] executed in 9s793ms
20:28:47.539 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher       : Job: [SimpleJob: [name=compare-job]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 9s804ms

When the same commands are run with wider screen size, the lines with SEVERE do not show up at all.

$ ./riot-3.1.1/bin/riot -i <source> replicate <target> --mode compare --show-diffs
21:03:08.323 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-job]] launched with the following parameters: [{}]
21:03:08.348 INFO org.springframework.batch.core.job.SimpleStepHandler	: Executing step: [compare-step]
Comparing   0% [                                                                                                                                       ]    0/5006 (0:00:00 / ?) ?/s
21:03:08.851 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-step-reader-left]] launched with the following parameters: [{}]
Comparing  44% [========================================                                                   ] 2250/5006 (0:00:04 / 0:00:05) 562.5/s 0 missing, 0 type, 0 value, 0 ttl
Comparing  98% [=========================================================================================  ] 4950/5006 (0:00:08 / 0:00:00) 618.8/s 0 missing, 0 type, 1 value, 0 ttl
21:03:17.605 INFO org.springframework.batch.core.step.AbstractStep	: Step: [compare-step-reader-left-step] executed in 8s748ms
21:03:17.610 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-step-reader-left]] completed with the following parameters: Comparing  99% [========================================================================================== ] 5000/5006 (0:00:09 / 0:00:00) 555.6/s 0 missing, 0 type, 1 value, 0 ttl
Comparing 100% [===========================================================================================] 5006/5006 (0:00:09 / 0:00:00) 556.2/s 0 missing, 0 type, 1 value, 0 ttl
21:03:17.818 INFO org.springframework.batch.core.step.AbstractStep	: Step: [compare-step] executed in 9s470ms
21:03:17.820 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-job]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 9s480ms
jruaux commented

Can you try with 3.1.3? It has fixes for this kind of issues

Yes, v.3.1.3 seems to have fixed this. Thank you.