redromnon/HeroicBashLauncher

[Bug] Setup.sh fails because it cannot find the requests python module with flatpak

Baaba0rum opened this issue · 4 comments

Baaba0rum commented

Before posting this issue, make sure you've read the Issues section in the Readme and the Flatpak/Steam-Deck guide.

Describe the bug
I am on a Linux Desktop with a flatpak install of HeroicLauncher.
After running the setup.sh script, it is unable to launch the HeroicBashLauncher script with this error :

Traceback (most recent call last):
  File "func/HeroicBashLauncher.py", line 3, in <module>
ModuleNotFoundError: No module named 'requests'
[15357] Failed to execute script 'HeroicBashLauncher' due to unhandled exception!

I have requests installed with pip. It is located in /usr/lib/python3/dist-packages

To Reproduce
Steps to reproduce the behavior:

  1. Unzip in folder /home/user/Games/Heroic/HeroicBashLauncher/
  2. run setup.sh
  3. run ./HeroicBashLauncher 4. See error

Expected behavior
I expected the script to work and to find my python modules.

Details

  • Platform: Desktop
  • OS: Ubuntu 20.04
  • Heroic Version: Flatpack 2.3.9
  • Bash Launcher Version: 2.7.4
redromnon commented

I have to update the build.yml file to install "requests" since it has to be seperately installed via pip.

Baaba0rum commented

Is there a way for me to make the launch script work with a little hack ? Or do I need to wait for the next release ?

redromnon commented

I'll upload a new release in a while. Can you try if this build works? - https://github.com/redromnon/HeroicBashLauncher/actions/runs/2549166587

Baaba0rum commented

Yep that worked !
Thanks for the fast help!

  • 👍1