Add support for commodity and account entries.
Closed this issue · 3 comments
savingsandloan commented
The proposed changes would add support for Commodity & Account entries
- Readers: Add
get_commodity_entries
andget_account_entries
methods to readers (ofxreader, csvreader, csv_multitable_reader) - Common Importers: Add configurable checks of
self.include_commodities
andself.include_accounts
to investments.py (any other relevant importers?) - Common Importers: Add
extract_commodities
andextract_accounts
methods that would be called withinextract
if associatedinclude_
is set to true.
An earlier approach to this in fidelity_csv_old
was commits:
It would largely be the same except of course carry the new approach to build_metadata as done in #28
redstreet commented
Thanks, this helps! How about this commit instead? Would it solve all your needs?
savingsandloan commented
Technically should. It does introduce some questions of why other libreader methods (e.g. get_balance_positions
) are there (and leads to questions around the framing around ofx), but let me see how this works.
redstreet commented
Merged to main.