reduxjs/redux-devtools

Uncaught TypeError: Converting circular structure to JSON when redux-form

juanpasolano opened this issue · 6 comments

juanpasolano commented

Hi thanks for the awesome project.
Just to report an issue when having redux-devtools and redux-form.
When you implement the simplest example in redux-form you get the error Uncaught TypeError: Converting circular structure to JSON.

zalmoxisus commented

Probably you use persistState, don't you? Does this happen without debug_session set?

gaearon commented

Can you please write the stack trace?

zalmoxisus commented

Actually, it's easy to reproduce, just by having circular references in states, which throughs in JSON.stringify. Don't know about redux-form, but I used to have this problem with redux-router, which uses circular references.

In chrome extension we use jsan, which handle circular references, and as it tries first to do JSON.stringify, there's no performance impact.

Will send a PR with tests in a couple of days.

  • 👍5
gaearon commented

👍

In general having circular references is not very good by itself. cc @erikras

juanpasolano commented

Do you guys still need the stack trace?

erikras commented

Thanks for the cc. This is news to me. Yes, @juanpasolano, the stack trace would be nice.