reduxjs/redux-devtools

Monorepo

zalmoxisus opened this issue · 15 comments

zalmoxisus commented

As discussed before, moving all redux-devtools related repositories to reduxjs organization doesn't look sustainable (though it's still open for discussion). A better way, especially for new contributors, would be to have everything in a monorepo. We could do that in redux-devtools-extension as discussed in zalmoxisus/redux-devtools-extension#412 since there's more activity, but using just redux-devtools name sounds better and everything started here. So the plan is to keep only this repository, the rest will be archived and the code moved here. I'll add credits for every readme. Maybe we could even add authors of the monitors in the extension, just need an UI for that (something like a monitors store).

The list of repos to be merged (some will be renamed as suggested bellow):

These repositories could still be maintained outside as either having a maintainer or no changes needed in future (?):

If everybody agrees on, we still have to finish the work in progress in opened PRs, so first will need to:

  • fix all issues, except feature requests, for 2.16,
  • finish stack trace functionality started in zalmoxisus/remotedev-app#43 and move to a separate redux-devtools-trace-monitor package,
  • finish all refactoring, work in progress, implement new UI and all the updates for 3.0.
alexkuz commented

I'm okay with moving it wherever :)

  • 👍3
zalmoxisus commented

@alexkuz thanks for the reply! I granted permissions for this repository to you. Would you like to continue to maintain react-json-tree or better to move it here too? There are no critical issues with it, just few improvements we'll need merged.

alexkuz commented

I'd better move it too since I barely support my projects lately

zalmoxisus commented

Thanks @alexkuz! When you have some time, please add me as a collaborator to that repo and on npm.

alexkuz commented

@zalmoxisus done

  • ❤️1
herodrigues commented

That's a clever idea, because there are a lot of "redux-ish" development applications.
It should be something way more simple just like react-devtools.

A browser extension and a standalone Electron app would be enough.
Themes and monitors should be part of the main package.

Also, there are too many projects for simple things and they all have many dependencies (most of them are outdated).
i'm willing to help on this 😄

  • 👍1
zalmoxisus commented

@herodrigues definitely, it'll be easier to maintain and contribute. There are use cases where using monitors separately is useful (at least till we offer the ability to run the extension directly from client part solving serialization perf issues). Also react-native-debugger and integrations for non-redux are relying on our packages. The monorepo lets us maintain everything like a single package, but still providing the same multiple npm packages.

I did first steps in #416, which seems to work seamlessly. Will move more packages next week.

If you can help with configurations, upgrading dependences, tests, docs..., it'll be much appreciated ☺️

zalmoxisus commented

And yes, providing an electron app for redux-devtools-app which will silently launch websocket server (without adding remotedev-server to the client app) is needed. I was exploring using Chrome Native Messaging instead, but it still requires a messaging host, so there are no advantages comparing to current approach of using socketcluster/ remotedev-server bridge.

  • 👍1
herodrigues commented

@zalmoxisus how is it going with the browser extension?

  • 👀3
Methuselah96 commented

@alexkuz Do you mind if we also move react-base16-styling over here? react-json-tree relies on it pretty heavily and it would be convenient to be able to update its dependencies and/or types.

alexkuz commented

@Methuselah96 sorry, I've missed the mention - I don't mind, tell me if I should add you or @zalmoxisus as collaborator.

Methuselah96 commented

@alexkuz No worries. thanks. If you could add me that would great. @zalmoxisus isn't active right now.

Methuselah96 commented

@alexkuz Can we move react-dock here as well? It has some React 16 deprecation warnings that it would be great to resolve (see alexkuz/react-dock#40 (comment)). npm username is methuselah96. Thanks!

alexkuz commented

@Methuselah96 sure, you should have your access now.

  • 🎉1
Methuselah96 commented

Closing since all of the packages mentioned have been moved here. See #530 for future plans.