Tutorial page -> [Edit this page link]
TawfikYasser opened this issue · 12 comments
Hi
I think the Edit this page link doesn’t work in the Tutorial page -> Welcome to Redwood
And I think also all Edit this page link in all the tutorial doesn’t work. 👇
When clicking on it, It displays Not found 👇
I think this because the link provided in href as follows : Edit this page and this doesn’t work.
It doesn’t go to this page : welcome-to-redwood.md 👇
If I’m true, I will be very lucky to fix this
bug, And I will ask for a question
And If I’m wrong, Sorry and I will be careful again.
Thanks
Looping in @clairefro
@TawfikYasser recently worked with me to update Redwood Docs -- a first contribution to Redwood repos! Could you take a look here and confirm 1) the redirect is not using the correct domain and 2) what the redirect needs to do (regardless of domain)? This might be sorted once deployed and/or might be a bug with Docusaurus v2. If it's something we can fix on our end, Claire, please do provide @TawfikYasser with some initial direction.
Thanks everyone!
Thanks @thedavidprice , I will do my best
I am waiting for @clairefro :)
Hi @TawfikYasser ! This is indeed a bug.
It appears that this is set in the docusaurus.config file under presets > docs > editUrl
Looks like it may need to be changed from
https://github.com/redwoodjs/learn.redwoodjs.com/
to
https://github.com/redwoodjs/learn.redwoodjs.com/blob/main/
I'm not sure how to ensure people do not commit directly to main when they make edits. Hopefully the branch protection (no merge without review) will take care of this?...
I’m really sorry @clairefro for that.
I will work on a separate branch next time, I promise you. Sorry
Please explain to me how to fix the issue, Because I don’t understand what you said :
It appears that this is set in the docusaurus.config file under presets > docs > editUrl
Looks like it may need to be changed from
https://github.com/redwoodjs/learn.redwoodjs.com/
to
https://github.com/redwoodjs/learn.redwoodjs.com/blob/main/
@clairefro Do you mean this line ?
@clairefro Do you mean this line ?
Exactly! That base url should change to one that actually works on Github.
It seems that adding /blob/main/ to the end might work -could you try that out?
I’m really sorry @clairefro for that.
I'm not sure what you're apologizing for! No worries, and thank you for taking this on! :) (the talk about edits was for people that click the "Edit this page" link)
Okay @clairefro
I am apologizing about working in the main branch -> If you talking about me 😅
I will try to edit the link now
Thanks and sorry for any misunderstandings
PR opened #50 @clairefro
Great chance for me :)