Overview of broken theme elements after rehash.
Closed this issue · 15 comments
Instead of creating 12 new issues, I will create a single one with some issues and inconsistencies as to not spam you full of tickets. Screenshots attached obviously so you'll have a broad idea of the issues.
-
The server list now has a very unfitting and ugly bar.
-
Color overwrite only applies when hovering.
-
Color overwrite no longer applied to folders.
-
Color overwrite no longer applies to create + find server button.
-
Color overwrite no longer applies to the add friend button.
-
Color overwrite no longer applies to online status.
-
Color overwrite no longer applies to "Voice Connected"
-
Default theming clashes with midnight theme when deleting a message, making the date unreadable.
-
Text color applies to "start an activity" button. Horrible contrast, makes it unreadable.
-
Old bordering bug in fullscreen mode when calling returned.
-
Join Voice button no longer color overwritten (not sure if that was the case before the rehash either but it's just something I noticed)
-
Delete button is color overwritten, but only when you're not hovering. Hover over it and it will become red.
-
Scroll wheel is missing in the menu.
#1 is intentional. I wasn't sure if people would like it but I thought it looked a bit more consistent. Is it really that bad?
I will keep working on color override fixes, those are just manual additions. Thanks for showing me all these.
What exactly does #10 mean?
When in a call, full screen mode has a rounded border. The first screenshot is Discord themed, the second is vanilla. Compare the theme and unthemed borders.
#1 is intentional. I wasn't sure if people would like it but I thought it looked a bit more consistent. Is it really that bad?
I will keep working on color override fixes, those are just manual additions. Thanks for showing me all these.
I think it looks really poor, simply because I liked how it previously smoothed to the window bar, like in the vanilla theme.
When in a call, full screen mode has a rounded border. The first screenshot is Discord themed, the second is vanilla. Compare the theme and unthemed borders.
I'll have to look into this. It might not be possible to hide the border without using more :has() selectors, which are terrible for performance (see #34). I honestly don't mind it too much.
When in a call, full screen mode has a rounded border. The first screenshot is Discord themed, the second is vanilla. Compare the theme and unthemed borders.
I'll have to look into this. It might not be possible to hide the border without using more :has() selectors, which are terrible for performance (see #34). I honestly don't mind it too much.
Yeah, it's not that bad, but it used to be fixed so I just pointed out.
Obviously the fix doesn't apply anymore but if you can't fix it then I'd also say this should be lower on the priority list. #9 (comment)
issue #9 is different though. i think the borders existed, but were inconsistent in size.
2, 3, 8, 12, and 13 fixed.
10 is not really a problem, it not be changed because I don't want to have to use more :has() selectors. I'm pretty sure it has been like that for the past few months anyway.
I sorta like how 1 is right now. I'll keep it for now until more people complain about it. If you hate it you can remove the /* separate guilds panel */ section in the code.
With BetterFolders now fixed, it creates a second server bar when you're dropping the folder down that almost looks like it's overlapping other UI elements.
Although I wouldn't worry too much about it, as it's your theme and more of an issue with the plugin.
With the removed separate guild panel, the server bar no longer transitions into the window bar, due to added vignette on the top and bottom of the server bar.
It does however, fix the overlapping UI elements caused by the separate server panel.
cant tell if this is intentional or not but the size is inconsistent so id assume it isnt
cant tell if this is intentional or not but the size is inconsistent so id assume it isnt
I was playing around with some css snippets, and accidentally included it in the theme. I'll remove it.
cant tell if this is intentional or not but the size is inconsistent so id assume it isnt
fixed
4, 5, 6, 7, 11 fixed.
@makimwah I will be keeping the separate server list for now, but if you hate it you can remove this section:
like the comments say, make sure to uncomment the very bottom part to revert the folder colors.
closing this issue because everything else brought up here their own issues