caption popup does not save input
Closed this issue · 11 comments
Maybe i did something wrong but for me the "Done" button is not working. I can only close the window by pressing x.
Nearly forgot to mention that i only get this issue when running refinery-edge and rails 3.1
Are you running the rails-3-1 branch of this plugin?
yes
I'm experiencing this with Refinery 1.0.8 on Heroku as well. Works fine locally in development mode.
I may be experiencing an altogether different problem, because I think the problem must be in my code. I've done some digging to try to see if I can find what's even causing this problem. I can't. Here's what I've tried so far:
- diff the html output between production/development modes (they're identical)
- rolling back back versions of
refinerycms-page-images
back to 0.9.9 - rolling back to Refinery 1.0.7
- throwing an alert between lines 121-122 (the alert wouldn't display).
- putting the
$.proxy(...)
inside an anonymous function - disabling as many other gems as possible
I generated a fresh Refinery 1.0.8 project, and the problem was not there. I tried to bring it in by:
- pulling the database from the server that was having the problem (still works)
- installing
dalli
gem and settingconfig.cache_store = :dalli_store
- enabling
cache_pages_backend
- copying the database from my new project to the one I am having trouble with (still broken)
The only admin code I have is _additional_dashboard_menu_items.html.erb
and one action added to admin/dashboard_controller.rb
.
I realize that because it's not present in a stock Refinery app, it's probably something I did. I just think it's weird that I would have this problem in production mode but not in development mode.
same here. captions cannot be safed in 3.1 branch.
rails 3.1.3
edge via git
page-images branch 3.1
when trying to add a caption to an page image
- there is the error '[missing "en.refinery.js.admin.page_images.done" translation]' where there should be a title
- there is the error '[missing "en.refinery.js.admin.page_images.done" translation]' where there should be a safe button
when clicking on the button that should be the safe button nothing happens.
(saving works in the main branch on refinery gem version btw)
I had a public/javascripts/jquery-min.js in my project. When I deleted it, my problem was fixed. Not sure why it would break it. Does RefineryCMS use a custom version of jQuery?
Bizarre...
Yep, we do, but not for too much longer. The flavour of ours is in https://github.com/resolve/refinerycms/blob/1-0-stable/core/doc/included-jquery-ui-packages.jpg
That would explain it! Hopefully that will fix everyone else's problem as well...
On Refinery 1.0.8 and Page Images 1.0.4...
I was also running a newer version of jQuery at /public/javascripts/jquery.js which was accidentally overriding the bundled version of jQuery that Refinery provides in the gem.
Removing the newer version of jQuery (or renaming/moving it to a subdirectory) solved a few issues: The caption popup's "Done" button now retains the changes you've made, and caption text no longer shuffles around to different images when you reorder/add/remove images.
The only remaining issue is that the caption popup's [X] button does not wipe any changes you made to the caption. It just acts as another Done button. This may have been done by design, however, and not be a bug.
Hi, this is kind of old with no activity so closing it.. please re-open if this is still an issue.