reg-viz/reg-suit

reg-publish-s3-plugin download limit

samturrell opened this issue · 1 comments

samturrell commented

Describe the bug

Hi there,

In recent weeks I have noticed that the results in the VRT results when used with the s3 plugin have yielded a lot of "new" items which aren't actually new at all.

Upon looking into the issue, it seems that the maximum number of files ever downloaded from the bucket is 3000, as per the attached screenshot.

As you can see there are much more than 3000 files generated - 6301 in this case - so i would expect it to be downloading many more here.

Reproduced step

Steps to reproduce the behavior:

  1. Create storybook with a large amount of stories (3000+)
  2. Run storycap and reg suit with the reg-publish-s3-plugin plugin
  3. Make some changes and commit
  4. Run storycap and reg suit again
  5. Notice that only 3000 files are downloaded for comparison

Expected behavior

All images are downloaded for the comparison

Actual behavior

A maximum of 3000 images are downloaded for the comparison

Screenshots

image

Quramy commented

@samturrell Sorry for my late reply .

I've merged your PR and published as v0.10.17. Thx !