[reg-publish-s3-plugin] Downloading objects never finishes when there are more than 1000 objects in the download
fukumasuya opened this issue · 0 comments
fukumasuya commented
Describe the bug
It seems reg-publish-s3-plugin
does not list all objects in the downloading process when there are more than 1000 objects.
The plugin passes Marker
parameter to ListObjectsV2Command
to get all objects recursively.
But ListObjectsV2Command
does not support Marker
and ignores it. So ListObjectsV2Command
is called infinitely..
We should use ContinuationToken
instead.
reg-suit/packages/reg-publish-s3-plugin/src/s3-publisher-plugin.ts
Lines 167 to 173 in cf3ba8c
Reproduced step
Steps to reproduce the behavior:
- Prepare an environment that has more than 1000 objects in a S3 bucket
- Run reg-suit with reg-publish-s3-plugin
Expected behavior
Downloading items finishes.
Actual behavior
Downloading items never finishes.